[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #33: [FLINK-26346] Add statistics collecting to sst files

[GitBox]

JingsongLi commented on a change in pull request #33:
URL: https://github.com/apache/flink-table-store/pull/33#discussion_r821524301



##########
File path: 
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/stats/FieldStatsCollector.java
##########
@@ -35,7 +35,7 @@ public FieldStatsCollector(RowType rowType) {
         this.minValues = new Object[numFields];
         this.maxValues = new Object[numFields];
         this.nullCounts = new long[numFields];
-        this.converter = new RowDataToObjectArrayConverter(rowType);
+        this.converter = new RowDataToObjectArrayConverter(rowType, true);

Review comment:
       I think we can just copy the field in `minValues[i] = c;` and 
`maxValues[i] = c;`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org