rkhachatryan commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r820504848



##########
File path: 
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof 
CancellationException) {
+                                // likely due to task cancellation or abortion 
notification
+                                LOG.info("materialization cancelled", 
throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       Regarding the code, do you disagree only with the comment -the part 
about checkpoint abortion?
   If so, I could remove that part.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to