[
https://issues.apache.org/jira/browse/FLINK-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424637#comment-15424637
]
ASF GitHub Bot commented on FLINK-4414:
---------------------------------------
GitHub user wenlong88 opened a pull request:
https://github.com/apache/flink/pull/2381
[FLINK-4414][cluster management] Remove restriction on RpcService.getAddress
currently RpcService provide only address of the endpoint, I think rpc
service serve both the endpoint create on it and the remote gateway create on
it, so it is ok to offer the getAddress to all RpcGateway created on the rpc
service including the server and client.
some more changes included, since ther merged in code base:
1. remove restriction of getAddress in RpcService
2. add support of Endpoint inherit and RpcGateway interface inherit
3. add some unittest for AkkaRpcService, remove JobMaster Register Test
4. add error handle method RpcEndpoint, which is a common function for
RpcEndpoint
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba/flink rpc_improvement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2381
----
commit 1971f26cc5d0afa4022b3daa93eacd9f9541b072
Author: wenlong.lwl <wenlong....@alibaba-inc.com>
Date: 2016-08-17T14:09:54Z
1. remove restriction of getAddress in RpcService
2. add support of Endpoint inherit and RpcGateway interface inherit
3. add some unittest for AkkaRpcService, remove JobMaster Register Test
4. add error handle method RpcEndpoint, which is a common function for
RpcEndpoint
commit bd1f8b1877ca6e7df6e7ed73d70846d6e598c06b
Author: wenlong.lwl <wenlong....@alibaba-inc.com>
Date: 2016-08-17T14:18:23Z
remove error process method since had been added in RpcEndpoint
----
> Remove restriction on RpcService.getAddress
> -------------------------------------------
>
> Key: FLINK-4414
> URL: https://issues.apache.org/jira/browse/FLINK-4414
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Wenlong Lyu
> Assignee: Wenlong Lyu
>
> currently {{RpcService}} provide only address of the endpoint, I think rpc
> service serve both the endpoint create on it and the remote gateway create on
> it, so it is ok to offer the getAddress to all {{RpcGateway}} created on the
> rpc service including the server and client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
