echauchot commented on a change in pull request #18610:
URL: https://github.com/apache/flink/pull/18610#discussion_r819446545
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContextTest.java
##########
@@ -155,6 +156,40 @@ private void testAssignSplitToUnregisterdReader(boolean
fromCoordinatorExecutor)
"Cannot assign splits");
}
+ @Test
+ public void testExceptionInRunnableFailsTheJob()
+ throws InterruptedException, ExecutionException {
+ ManuallyTriggeredScheduledExecutorService manualWorkerExecutor =
+ new ManuallyTriggeredScheduledExecutorService();
+ // need the factory to have the exception handler set
+ final ManuallyTriggeredScheduledExecutorService
coordinatorExecutorWithExceptionHandler =
+ new ManuallyTriggeredScheduledExecutorService(1,
coordinatorThreadFactory);
Review comment:
another comment, `wrap()` was introduced in the PR before using
`ManuallyTriggeredScheduledExecutorService` when
`Executors.newSingleThreadScheduledExecutor` was in use. It was introduced
because `ScheduledFutureTask` catches its own exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
