[ 
https://issues.apache.org/jira/browse/FLINK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421184#comment-15421184
 ] 

ASF GitHub Bot commented on FLINK-4373:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2370#discussion_r74785154
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/AllocationID.java
 ---
    @@ -0,0 +1,38 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework.types;
    +
    +import org.apache.flink.util.AbstractID;
    +
    +/**
    + * Unique identifier for the attempt to allocate a slot, normally created 
by JobManager when requesting a slot,
    + * constant across re-tries. This can also be used to identify responses 
by the ResourceManager and to identify
    + * deployment calls towards the TaskManager that was allocated from.
    + */
    +public class AllocationID extends AbstractID {
    +
    +   private static final long serialVersionUID = 1L;
    +
    +   /**
    +    * Creates an new random allocation ID.
    +    */
    +   public AllocationID() {
    +           super();
    +   }
    --- End diff --
    
    This constructor is the standard default constructor, right? I guess we 
don't need to specify this constructor then.


> Introduce SlotID, AllocationID, ResourceProfile
> -----------------------------------------------
>
>                 Key: FLINK-4373
>                 URL: https://issues.apache.org/jira/browse/FLINK-4373
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Kurt Young
>            Assignee: Kurt Young
>
> For the new version of cluster management, we need some more basic data 
> structures:
> * SlotID: Identifier of one single slot located in a task executor
> * AllocationID: Slot allocation identifier, created by the JobManager when 
> requesting a slot, constant across re-tries. Used to identify responses by 
> the ResourceManager and to identify deployment calls towards the TaskManager 
> that was allocated from.
> * ResourceProfile: The resource profile of the desired slot (currently only 
> cpu cores and memory are supported



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to