[ 
https://issues.apache.org/jira/browse/FLINK-25286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495611#comment-17495611
 ] 

Francesco Guardiani commented on FLINK-25286:
---------------------------------------------

Hi all,
Just seen this now and I was wondering, perhaps this should have been a FLIP, 
given all the APIs are annotated as experimental? Or at least is there a doc 
shared publicly where i can look at the design? Can you also add a README at 
the root of the module, in order to explain the architecture and how this can 
be used?

I have a couple of questions:

* From a quick look, it sounds like this is a completely new injection 
framework. Is there some area where we can reuse the injection provided by 
JUnit 5 instead?
* Can we rely on {{MiniClusterExtension}} for {{MiniCluster}} setup and 
teardown?
* Can the tests run in parallel using the new JUnit 5 parallel execution 
feature?
* We have ArchUnit tests in 
{{flink-architecture-tests/flink-architecture-tests-test}} looking for the 
{{MiniClusterExtension}} or the rule {{MiniClusterResource}}, which now are 
going to fail when you use this new framework (see the pulsar connector). Can 
you please upgrade these rules as well? 

Thank you,
FG

> Improve connector testing framework to support more scenarios
> -------------------------------------------------------------
>
>                 Key: FLINK-25286
>                 URL: https://issues.apache.org/jira/browse/FLINK-25286
>             Project: Flink
>          Issue Type: Improvement
>          Components: Test Infrastructure
>            Reporter: Qingsheng Ren
>            Assignee: Hang Ruan
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Currently connector testing framework only support tests for DataStream 
> sources, and available scenarios are quite limited by current interface 
> design. 
> This ticket proposes to made improvements to connector testing framework for 
> supporting more test scenarios, and add test suites for sink and Table/SQL 
> API.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to