JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r810298689
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java
##########
@@ -35,12 +35,20 @@
implements SinkWriterMetricGroup {
private final Counter numRecordsOutErrors;
+ private final Counter numRecordsWritten;
+ private final Counter numBytesWritten;
private final OperatorIOMetricGroup operatorIOMetricGroup;
private InternalSinkWriterMetricGroup(
MetricGroup parentMetricGroup, OperatorIOMetricGroup
operatorIOMetricGroup) {
super(parentMetricGroup);
numRecordsOutErrors =
parentMetricGroup.counter(MetricNames.NUM_RECORDS_OUT_ERRORS);
+ numRecordsWritten =
+ parentMetricGroup.counter(
+
org.apache.flink.runtime.metrics.MetricNames.IO_NUM_RECORDS_OUT);
Review comment:
hmm, thanks for pointing it out. I have two questions.
First question, Which counter with the same name do you mean? Do you mean
the one within the `operatorIOMetricGroup`? Both of them have the same name but
belong to different metricGroups. It is intended to define the second counter
for the same records output purpose. This one is used for SinkWriter and the
other one within the `operatorIOMetricGroup` is used for the
`SinkWriterOperator `.
Second question, What do you mean "never exported"? Is there anything else
should be done to make it be exported? Do we have tech guide somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
