[
https://issues.apache.org/jira/browse/FLINK-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420644#comment-15420644
]
ASF GitHub Bot commented on FLINK-4281:
---------------------------------------
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2372
[FLINK-4281] [table] Wrap all Calcite Exceptions in Flink Exceptions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
Wrap all calcite exceptions to Flink Exceptions in `FlinkPlannerImpl`. I
can't find other exceptions thrown by Calcite, if any I will wrap it later.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink FLINK-4281
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2372
----
commit 4c233c0d3847a8a484ef34aee703c61c159c69c5
Author: Jark Wu <wuchong...@alibaba-inc.com>
Date: 2016-08-15T05:54:09Z
[FLINK-4281] [table] Wrap all Calcite Exceptions in Flink Exceptions
----
> Wrap all Calcite Exceptions in Flink Exceptions
> -----------------------------------------------
>
> Key: FLINK-4281
> URL: https://issues.apache.org/jira/browse/FLINK-4281
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> Some exceptions are already wrapped in Flink exceptions but there are still
> exceptions thrown by Calcite. I would propose that all Exceptions thrown by
> the Table API are Flink's Exceptions, esp. the FlinkPlannerImpl exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
