JingGe opened a new pull request #18825:
URL: https://github.com/apache/flink/pull/18825
## What is the purpose of the change
We found that the new sink v2 interface will have a wrong numRecordsOut
metric for the sink writers. We send a fixed number of records to the source,
but the numRecordsOut of the sink continues to increase by the time.
The problem is that both the `SinkWriterOperator` and the `KafkaWriter` are
using the same counter metric for counting the outgoing records. Same records
sent by the `SinkWriterOperator` to the post topology and written by the
`KafkaWriter` to the downstream system will be count twice in the same counter
metric.
## Brief change log
- define new counters in `SinkWriterMetricGroup`
- replace the shared counter used in `KafkaWriter` with new counters
- update `KafkaWriterITCase`
- enable `KafkaSinkITCase` and `KafkaSinkE2ECase` again
## Verifying this change
This change is already covered by existing tests, such as
`KafkaWriterITCase`, `KafkaSinkITCase`, and `KafkaSinkE2ECase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (will be done in a follow-up PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
