[ 
https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420255#comment-15420255
 ] 

ASF GitHub Bot commented on FLINK-3866:
---------------------------------------

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2289
  
    Hi @mushketyk, I'll try to find somebody to review this


> StringArraySerializer claims type is immutable; shouldn't
> ---------------------------------------------------------
>
>                 Key: FLINK-3866
>                 URL: https://issues.apache.org/jira/browse/FLINK-3866
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.3
>            Reporter: Tatu Saloranta
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>
> Looking at default `TypeSerializer` instances I noticed what looks like a 
> minor flaw, unless I am missing something.
> Whereas all other array serializers indicate that type is not immutable 
> (since in Java, arrays are not immutable), `StringArraySerializer` has:
> ```
>       @Override
>       public boolean isImmutableType() {
>               return true;
>       }
> ```
> and I think it should instead return `false`. I could create a PR, but seems 
> like a small enough thing that issue report makes more sense.
> I tried looking for deps to see if there's a test for this, but couldn't find 
> one; otherwise could submit a test fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to