[ https://issues.apache.org/jira/browse/FLINK-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419965#comment-15419965 ]
ASF GitHub Bot commented on FLINK-4383: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2365 This is a great feature and it looks very good overall. Minor comments inline. Big +1 overall > Check parameters for serializability before sending a remote RpcInvocation > message > ---------------------------------------------------------------------------------- > > Key: FLINK-4383 > URL: https://issues.apache.org/jira/browse/FLINK-4383 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination > Reporter: Till Rohrmann > Assignee: Till Rohrmann > > Before sending a remote {{RpcInvocation}} message we should check that the > rpc arguments are serializable. If not we should eagerly fail with an > appropriate exception message. > If we don't do this, then Akka will silently fail serializing the message > without telling the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)