zentol commented on a change in pull request #18806:
URL: https://github.com/apache/flink/pull/18806#discussion_r808203046



##########
File path: flink-end-to-end-tests/test-scripts/common_ha.sh
##########
@@ -49,7 +49,7 @@ function verify_num_occurences_in_logs() {
     local text="$2"
     local expected_no="$3"
 
-    local actual_no=$(grep -r --include "*${log_pattern}*.log" -e "${text}" 
"$FLINK_LOG_DIR/" | cut -d ":" -f 1 | uniq | wc -l)
+    local actual_no=$(grep -r --include "*${log_pattern}*.log*" -e "${text}" 
"$FLINK_LOG_DIR/" | cut -d ":" -f 1 | sed "s/\.log\.[0-9]\{1,\}$/.log/g" | uniq 
| wc -l)

Review comment:
       ```suggestion
       local actual_no=$(grep -r --include "*${log_pattern}*.log*" -e "${text}" 
"$FLINK_LOG_DIR/" | cut -d ":" -f 1 | sed "s/log[.0-9]*$//g" | uniq | wc -l)
   ```
   we can simplify this a bit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to