XComp commented on a change in pull request #18749:
URL: https://github.com/apache/flink/pull/18749#discussion_r807639403
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableResource.java
##########
@@ -24,12 +24,11 @@
import java.util.concurrent.Executor;
/**
- * {@code LocallyCleanableResource} is supposed to be used by any class that
provides artifacts for
- * a given job that can be cleaned up locally. Artifacts considered to be
local are located on the
- * JobManager instance itself and won't survive a failover scenario. These
artifacts are, in
- * contrast to {@link GloballyCleanableResource} artifacts, going to be
cleaned up even after the
- * job reaches a locally-terminated state.
+ * {@code LocallyCleanableResource} is supposed to be implemented by any class
that provides
+ * artifacts for a given job that need to be cleaned up after the job reached
a local terminal
Review comment:
I created FLINK-26175 to cover the refactoring. Looking at the code of
the `StateHandleStore` implementations, we can actually separate it without
problems. I updated the JavaDoc once more mentioning the workaround in
`DispatcherResourceCleanerFactory` and pointing to this ticket as well. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
