[ 
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417626#comment-15417626
 ] 

ASF GitHub Bot commented on FLINK-4384:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/2360

    [FLINK-4384] [rpc] Add "scheduleRunAsync()" to the RpcEndpoint

    NOTE: This builds on top of #2357 - only the second commit belongs actually 
to this pull request is relevant.
    
    Add a `scheduleRunAsync()` method to the `RpcEndpoint`. It behaves like 
`runAsync()` but delays the call by a given number of milliseconds. The delay 
does not happen by a thread sleep, but by scheduling the message that triggers 
the Runnable it into the future of the message dispatcher.
    
    This also adds tests for the `runAsync()`, `scheduleRunAsync()`, and 
`callAsync()` that validate that all these calls actually run in the same 
thread (the RPC endpoint's main thread).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink schedule_future

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2360
    
----
commit 13f6f392943e32b14bf0d08c7ded2d88496911ab
Author: Till Rohrmann <trohrm...@apache.org>
Date:   2016-08-10T16:42:26Z

    [FLINK-4362] [rpc] Auto generate rpc gateways via Java proxies
    
    This PR introduces a generic AkkaRpcActor which receives rpc calls as a
    RpcInvocation message. The RpcInvocation message is generated by the
    AkkaInvocationHandler which gets them from automatically generated Java 
Proxies.
    
    Add documentation for proxy based akka rpc service

commit 7b9eb2f3de23a7bee28346664ff39e0c28235a6e
Author: Stephan Ewen <se...@apache.org>
Date:   2016-08-11T17:10:48Z

    [FLINK-4384] [rpc] Add "scheduleRunAsync()" to the RpcEndpoint

----


> Add a "scheduleRunAsync()" feature to the RpcEndpoint
> -----------------------------------------------------
>
>                 Key: FLINK-4384
>                 URL: https://issues.apache.org/jira/browse/FLINK-4384
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>         Environment: FLIP-6 feature branch
>            Reporter: Stephan Ewen
>             Fix For: 1.2.0
>
>
> It is a common pattern to schedule a call to be executed in the future. 
> Examples are
>   - delays in retries
>   - heartbeats,
>   - checking for heartbeat timeouts
> I suggest to add a {{scheduleRunAsync()}} method to the {{RpcEndpoint}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to