becketqin opened a new pull request #18745:
URL: https://github.com/apache/flink/pull/18745


   ## What is the purpose of the change
   Currently the closing sequence of the `OperatorCoordinator` does not swallow 
the exceptions thrown in the middle. So when exception is thrown in the middle, 
the rest of the closing sequence will be skipped. This patch makes the closing 
sequence of `OperatorCoordinator` more robust by swallowing the exception 
thrown in the middle, and also retries interrupting the threads in case the the 
closing sequence is blocked multiple times.
   
   Some of the methods, such as `closeQuietly()`, in the `IOUtils` seem better 
to be put in `ComponentClosingUtils`. Will do that in a separate PR. 
   
   ## Brief change log
   0dfe9b7 Add util methods to shutdown executor services.
   1cb9f56 Make OperatorCoordinator closure more robust.
   
   ## Verifying this change
   This change added the following unit tests:
   
   1. `ComponentClosingUtilsTest` class.
   2. `SourceCoordinatorTest.testBlockOnClose()` test method.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to