[ 
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416965#comment-15416965
 ] 

ASF GitHub Bot commented on FLINK-3874:
---------------------------------------

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/2244
  
    @mushketyk Thanks for your PR. I added some comments to the code. The 
changes you made to the `TableSink` class structure seem reasonable. However, 
it might be better if those change would be made in a separate Jira issue and 
PR.
    
    In general, it would be great if you try to touch as little existing code 
as possible and orientate yourself more on the existing code base.


> Add a Kafka TableSink with JSON serialization
> ---------------------------------------------
>
>                 Key: FLINK-3874
>                 URL: https://issues.apache.org/jira/browse/FLINK-3874
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>
> Add a TableSink that writes JSON serialized data to Kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to