dmvk commented on a change in pull request #18689:
URL: https://github.com/apache/flink/pull/18689#discussion_r803828457
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -1576,4 +1576,15 @@ public ExecutionDeploymentListener
getExecutionDeploymentListener() {
public boolean isDynamic() {
return isDynamic;
}
+
+ @Override
+ public Optional<ExecutionVertexID> getExecutionVertexId(ExecutionAttemptID
id) {
+ Execution execution = this.getRegisteredExecutions().get(id);
+ return
Optional.ofNullable(execution).map(Execution::getVertex).map(ExecutionVertex::getID);
+ }
+
+ @Override
+ public Optional<ExecutionVertex> getExecutionVertex(final
ExecutionVertexID executionVertexId) {
Review comment:
then let's focus on the more important parts of the PR;
In the places where this method is currently used, I'd say it should be a
fatal error. Basically it means that the executions that you've received
failures for are no longer part of the EG, which suggests a faulty
implementation. (assuming we're only call it in this `convertFailures` methods)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
