wangyang0918 commented on a change in pull request #18531:
URL: https://github.com/apache/flink/pull/18531#discussion_r801397500



##########
File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1685,6 +1699,35 @@ void addLibFoldersToShipFiles(Collection<File> 
effectiveShipFiles) {
         }
     }
 
+    @VisibleForTesting
+    void addUsrLibFolderToShipFiles(
+            Collection<File> effectiveShipFiles, Collection<File> 
systemShipFiles) {
+        // Add usrlib folder to the ship files if it exists
+        // Classes in the folder will be loaded by UserClassLoader if 
CLASSPATH_INCLUDE_USER_JAR is
+        // DISABLED.
+        final Optional<File> usrLibDir = getLocalUsrLibDirectory();
+
+        if (usrLibDir.isPresent()) {
+            File usrLibDirFile = usrLibDir.get();
+            if (usrLibDirFile.isDirectory()) {
+                checkArgument(

Review comment:
       What I mean is about `flink run/run-applicaton` on the client side. For 
the JobManager and TaskManager start commands, you are right that `config.sh` 
will not be executed. So I think we could have a dedicated ticket to fix the 
issue you comment under 
[FLINK-24897](https://issues.apache.org/jira/browse/FLINK-24897?focusedCommentId=17483689&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17483689).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to