twalthr commented on a change in pull request #18439:
URL: https://github.com/apache/flink/pull/18439#discussion_r794579842



##########
File path: 
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java
##########
@@ -426,6 +424,49 @@ public void testNullEnforcer() throws ExecutionException, 
InterruptedException {
         }
     }
 
+    @Test
+    public void testFromValuesWatermarkPropagation() throws Exception {
+        final StreamTableEnvironment tableEnv = 
StreamTableEnvironment.create(env);
+        final SharedReference<List<Long>> watermarks = sharedObjects.add(new 
ArrayList<>());
+        final TableDescriptor sinkDescriptor =
+                TableFactoryHarness.newBuilder()
+                        .schema(Schema.newBuilder().column("a", "INT").build())

Review comment:
       sorry, I wasn't clear enough: you are not using this descriptor as a 
source, so you can simply omit the schema, it will be derived automatically by 
`executeInsert`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to