twalthr commented on a change in pull request #18540:
URL: https://github.com/apache/flink/pull/18540#discussion_r794388640



##########
File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -414,6 +415,16 @@
                             "Determines whether CAST will operate following 
the legacy behaviour "
                                     + "or the new one that introduces various 
fixes and improvements.");
 
+    @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+    public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+            ConfigOptions.key("table.exec.topn.cache-size")

Review comment:
       `topn` is an outdated name. Use `rank` everywhere like 
`table.exec.rank.cache-size` to be consistent. The old key can be declared as a 
deprecated key.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to