Myasuka commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r790666268
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java
##########
@@ -302,14 +302,16 @@ public void reset(SequenceNumber from, SequenceNumber to)
{
}
private static ChangelogStateHandleStreamImpl buildHandle(
- KeyGroupRange keyGroupRange, NavigableMap<SequenceNumber,
UploadResult> results) {
+ KeyGroupRange keyGroupRange,
+ NavigableMap<SequenceNumber, UploadResult> results,
+ long incrementalSize) {
List<Tuple2<StreamStateHandle, Long>> tuples = new ArrayList<>();
long size = 0;
for (UploadResult uploadResult : results.values()) {
tuples.add(Tuple2.of(uploadResult.getStreamStateHandle(),
uploadResult.getOffset()));
size += uploadResult.getSize();
}
- return new ChangelogStateHandleStreamImpl(tuples, keyGroupRange, size);
+ return new ChangelogStateHandleStreamImpl(tuples, keyGroupRange, size,
incrementalSize);
Review comment:
If we take the pre-emptively uploaded changelogs as checkpointed data
size, the semantics would be broken as those changelogs does not uploaded in
that checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
