tillrohrmann commented on a change in pull request #18452:
URL: https://github.com/apache/flink/pull/18452#discussion_r790521866



##########
File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml
##########
@@ -214,6 +214,8 @@ under the License.
                                                                                
<exclude>META-INF/*.SF</exclude>
                                                                                
<exclude>META-INF/*.DSA</exclude>
                                                                                
<exclude>META-INF/*.RSA</exclude>
+                                                                               
<!-- exclude javax.annotation because of GPLv2 license, see 
https://github.com/apache/flink/pull/15599#issuecomment-850241316 -->
+                                                                               
<exclude>javax/annotation/**</exclude>

Review comment:
       Instead of filtering it out when the shading happens, can this 
dependency be excluded when depending on the dependency which pulls it it (e.g. 
in the `<dependencies>` section)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to