JingsongLi commented on a change in pull request #18412:
URL: https://github.com/apache/flink/pull/18412#discussion_r789390013
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -65,7 +67,9 @@
*
* @param <IN> The type of the input elements.
*/
-class KafkaWriter<IN> implements SinkWriter<IN, KafkaCommittable,
KafkaWriterState> {
+class KafkaWriter<IN>
+ implements SinkWriter<IN, KafkaCommittable, KafkaWriterState>,
+ MetadataPublisher<RecordMetadata> {
Review comment:
The big question is whether the `subscribe` call occurs before or after
serialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
