[
https://issues.apache.org/jira/browse/FLINK-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399100#comment-15399100
]
ASF GitHub Bot commented on FLINK-4277:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2310
[FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading
This PR fixes the
`TaskManagerConfigurationTest#testDefaultFsParameterLoading` by creating a
proper `flink-conf.yaml` file and passing the correct `--configDir` parameter.
Previously, the generated yaml had a random name (`<random UUID>.yaml`)
even though it should be called `flink-conf.yaml`. In addition, the
`--configDir` parameter was set to the file name, and not directory it resides
in.
I don't know why this test did not fail earlier; maybe @mxm has an idea as
he recently did some work on the `GlobalConfiguration`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4277_tm_configuration_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2310
----
commit fecd900b1030d0850ff8698ce85ee720c8cae613
Author: zentol <ches...@apache.org>
Date: 2016-07-29T10:15:54Z
[FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading
----
> TaskManagerConfigurationTest fails
> ----------------------------------
>
> Key: FLINK-4277
> URL: https://issues.apache.org/jira/browse/FLINK-4277
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
> When running this test on Ubuntu i encountered this error:
> Running org.apache.flink.runtime.taskmanager.TaskManagerConfigurationTest
> java.lang.Exception: Could not load configuration
> at
> org.apache.flink.runtime.taskmanager.TaskManager$.parseArgsAndLoadConfig(TaskManager.scala:1526)
> at
> org.apache.flink.runtime.taskmanager.TaskManager.parseArgsAndLoadConfig(TaskManager.scala)
> at
> org.apache.flink.runtime.taskmanager.TaskManagerConfigurationTest.testDefaultFsParameterLoading(TaskManagerConfigurationTest.java:125)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> Caused by: org.apache.flink.configuration.IllegalConfigurationException: The
> Flink config file
> '/tmp/26d1532e-a1f2-4007-bf77-f66c92669241/33c51581-617c-4029-8b6e-11b9a55c792b.yaml/flink-conf.yaml'
>
> (/tmp/26d1532e-a1f2-4007-bf77-f66c92669241/33c51581-617c-4029-8b6e-11b9a55c792b.yaml)
> does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
