tsreaper commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788313592
########## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.file; + +import org.apache.flink.core.fs.Path; +import org.apache.flink.table.store.file.utils.FileUtils; + +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonGetter; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonProcessingException; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper; + +import java.io.IOException; + +/** This file is the entrance to all data committed at some specific time point. */ +public class Snapshot { + + public static final long FIRST_SNAPSHOT_ID = 1; + + private static final String FIELD_ID = "id"; + private static final String FIELD_MANIFEST_LIST = "manifestList"; + private static final String FIELD_COMMITTER = "committer"; + private static final String FIELD_HASH = "hash"; + private static final String FIELD_TYPE = "type"; + + @JsonProperty(FIELD_ID) Review comment: We still need `@JsonGetter`s and field names, so no harm to also add `@JsonProperty` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
