slinkydeveloper commented on a change in pull request #18290:
URL: https://github.com/apache/flink/pull/18290#discussion_r785724720
##########
File path:
flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/HBase2DynamicTableFactory.java
##########
@@ -136,4 +133,20 @@ public String factoryIdentifier() {
set.add(LOOKUP_MAX_RETRIES);
return set;
}
+
+ @Override
+ public Set<ConfigOption<?>> forwardOptions() {
Review comment:
But in case of table factories, the docs generator will use the
`Factory` interface anyway. We've paved the idea of extending `ConfigOption`,
but it was way too complicated and impactful, hence we ended up with this
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
