zhuzhurk commented on a change in pull request #18102:
URL: https://github.com/apache/flink/pull/18102#discussion_r785638944
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingResultPartition.java
##########
@@ -48,11 +49,11 @@
ResultPartitionState getState();
/**
- * Gets the {@link ConsumerVertexGroup}.
+ * Gets the {@link ConsumerVertexGroup}. *
Review comment:
the trailing `*` should be removed.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -59,8 +59,10 @@
import org.apache.flink.runtime.jobgraph.JobVertex;
import org.apache.flink.runtime.jobgraph.JobVertexID;
import
org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobmanager.scheduler.SlotSharingGroup;
Review comment:
Looks to me commit 6cb03fe1f9824c011f752a416197d1e2004a2e11 (Support
calcuate network memory for dynamic graph.) is not related to the topic of this
PR "Let some scheduler components updatable"?
If not, would you create a separate ticket and PR to make this change?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -59,8 +59,10 @@
import org.apache.flink.runtime.jobgraph.JobVertex;
import org.apache.flink.runtime.jobgraph.JobVertexID;
import
org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobmanager.scheduler.SlotSharingGroup;
Review comment:
Looks to me commit 6cb03fe1f9824c011f752a416197d1e2004a2e11 (Support
calculate network memory for dynamic graph.) is not related to the topic of
this PR "Let some scheduler components updatable"?
If not, would you create a separate ticket and PR to make this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
