fapaul commented on a change in pull request #18330: URL: https://github.com/apache/flink/pull/18330#discussion_r784738375
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.connector.sink2; + +import org.apache.flink.annotation.Experimental; + +import javax.annotation.Nullable; + +import java.util.OptionalLong; + +/** + * This class tracks the information about committables belonging to one checkpoint coming from one + * subtask. + * + * <p>It is sent to down-stream consumers to depict the progress of the committing process. + * + * @param <CommT> type of the committable + */ +@Experimental +public class CommittableSummary<CommT> implements CommittableMessage<CommT> { Review comment: Yes, that's true but we cannot easily remove it. The only option is to remove the generic type from the CommittableMessage interface unfortunately, this makes consuming the DataStream from the topology i.e. `WithPreCommitTopology#addTopology` very difficuly because you do not have the type information anymore of the generic type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
