JingGe edited a comment on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012232986


   > Of course technically it seems like IntelliJ actually finds more correct 
violations, so the IntelliJ result is "more correct", but IntelliJ is not our 
source of truth.
   
   It means that maven and IntelliJ are running in different scopes, i.e. "more 
violations" will be found by IntelliJ because it use a bigger scope than maven, 
IMHO, it has nothing to do with correctness. It might be an issue 
(incorrectness) that ArchUnit should fix.
   
   > The problem here are the test-jars and how they're handled; we currently 
don't have an issue because we do not use JARs for the dependencies in the 
module.
   
   that is what I mentioned that complex scope has not been touched.
   
   > 
   > When IntelliJ executes the tests, it handles the dependencies differently 
than Maven, and that is causing the inconsistency. We can fix this by improving 
the import options to cover both scenarios equally.
   
   It sounds more like a compatible IntelliJ setup with maven project w.r.t. 
dependencies or ArchUnit abstracts and hides the hybrid dependencies with 
maven, IntelliJ, gradle, Bazel, etc.  than working on it within this PR?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to