[
https://issues.apache.org/jira/browse/FLINK-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394713#comment-15394713
]
ASF GitHub Bot commented on FLINK-4259:
---------------------------------------
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2299
[FLINK-4259]: Unclosed FSDataOutputStream in FileCache#copy(): Added a …
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
Description of Changes:
Add a close statement for closing the FSDataOutputStream.
Requesting review.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-4259]
Unclosed FSDataOutputStream in FileCache#copy()")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
…close statement to close the FSDataOutputStream object
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-4259
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2299
----
commit f77780aa9c997eeac3950cfd2194b7c08851ef8d
Author: Neelesh Srinivas Salian <[email protected]>
Date: 2016-07-25T20:30:42Z
FLINK-4259: Unclosed FSDataOutputStream in FileCache#copy(): Added a close
statement to close the FSDataOutputStream object
----
> Unclosed FSDataOutputStream in FileCache#copy()
> -----------------------------------------------
>
> Key: FLINK-4259
> URL: https://issues.apache.org/jira/browse/FLINK-4259
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Neelesh Srinivas Salian
> Priority: Minor
>
> {code}
> try {
> FSDataOutputStream lfsOutput = tFS.create(targetPath, false);
> FSDataInputStream fsInput = sFS.open(sourcePath);
> IOUtils.copyBytes(fsInput, lfsOutput);
> {code}
> The FSDataOutputStream lfsOutput should be closed upon exit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
