tillrohrmann commented on a change in pull request #18220: URL: https://github.com/apache/flink/pull/18220#discussion_r778927801
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientProvider.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.client.program.ClusterClient; +import org.apache.flink.client.program.ClusterClientProvider; +import org.apache.flink.client.program.rest.RestClusterClient; +import org.apache.flink.configuration.Configuration; + +import org.apache.hadoop.yarn.api.records.ApplicationId; +import org.apache.hadoop.yarn.api.records.ApplicationReport; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.flink.yarn.YarnClusterDescriptor.setClusterEntrypointInfoToConfig; + +/** The implementation of ClusterClientProvider. */ Review comment: Maybe say what the `YarnClusterClientProvider` does. E.g. waiting for the job to be running and then creating a `RestClusterClient` with the respective connection information. ########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/ApplicationReportProvider.java ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.flink.annotation.Internal; + +import org.apache.hadoop.yarn.api.records.ApplicationReport; + +/** ApplicationReportProvider. */ +@Internal +public interface ApplicationReportProvider { + ApplicationReport waitTillSubmissionFinish() throws Exception; Review comment: I meant the JavaDoc for `waitTillSubmissionFinish` that describes the behaviour of it. ########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/ApplicationReportProviderImpl.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.flink.annotation.Internal; + +import org.apache.hadoop.yarn.api.records.ApplicationId; +import org.apache.hadoop.yarn.api.records.ApplicationReport; +import org.apache.hadoop.yarn.api.records.YarnApplicationState; +import org.apache.hadoop.yarn.client.api.YarnClient; + +import java.io.IOException; + +/** The implementation of ApplicationReportProvider. */ +@Internal +public class ApplicationReportProviderImpl implements ApplicationReportProvider { + private final YarnClient yarnClient; Review comment: I think it would be good to introduce utility that make access to the `YarnClient` fail if the client has been closed by the `YarnClusterDescriptor`. That way, we will get notified if the contract that the `ApplicationReportProviderImpl` does not outlive the `YarnClusterDescriptor` is violated. It would also make it clear that this component is not responsible for managing the lifecycle of the `yarnClient`. ########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientProvider.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.client.program.ClusterClient; +import org.apache.flink.client.program.ClusterClientProvider; +import org.apache.flink.client.program.rest.RestClusterClient; +import org.apache.flink.configuration.Configuration; + +import org.apache.hadoop.yarn.api.records.ApplicationId; +import org.apache.hadoop.yarn.api.records.ApplicationReport; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.flink.yarn.YarnClusterDescriptor.setClusterEntrypointInfoToConfig; + +/** The implementation of ClusterClientProvider. */ +@Internal +public class YarnClusterClientProvider implements ClusterClientProvider { + private static final Logger LOG = LoggerFactory.getLogger(YarnClusterClientProvider.class); + + private final Object lock = new Object(); Review comment: But the class is not marked as `@ThreadSafe`. Hence the calling code shouldn't let multiple threads use the same `Provider`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
