[ https://issues.apache.org/jira/browse/FLINK-25239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468513#comment-17468513 ]
Ada Wong commented on FLINK-25239: ---------------------------------- cc [~roman] Could assign to me, and review this pr. > Delete useless variables > ------------------------ > > Key: FLINK-25239 > URL: https://issues.apache.org/jira/browse/FLINK-25239 > Project: Flink > Issue Type: Improvement > Components: Connectors / JDBC, Table SQL / Ecosystem > Affects Versions: 1.14.0 > Reporter: Ada Wong > Priority: Minor > Labels: pull-request-available > Fix For: 1.15.0, 1.14.3 > > > DEFAULT_FLUSH_MAX_SIZE and DEFAULT_FLUSH_INTERVAL_MILLS in > JdbcOutputFormat class are useless. > We should delete them. > > {code:java} > public static final int DEFAULT_FLUSH_MAX_SIZE = 5000; > public static final long DEFAULT_FLUSH_INTERVAL_MILLS = 0L; {code} -- This message was sent by Atlassian Jira (v8.20.1#820001)