wsry commented on pull request #18173:
URL: https://github.com/apache/flink/pull/18173#issuecomment-1002618802


   > Do you mean introducing one more lock, above NetworkBufferPool? 
   
   No, it does not mean to introduce another lock, it tries to guarantee that 
when acquiring the global network lock, we are not holding the local buffer 
pool lock. But I think your solution which guarantees the locking order is 
better.
   
   > I'm not sure what would be a benefit of having this fix in a separate PR? 
It's not a release blocker, so I think we can fix it properly in this PR/issue.
   
   That also makes sense to me. I will fix it in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to