zuston commented on a change in pull request #18158:
URL: https://github.com/apache/flink/pull/18158#discussion_r776194977
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -137,6 +137,15 @@
.noDefaultValue()
.withDescription("JVM heap size (in megabytes) for the
JobManager.");
+ /** The maximum stacktrace depth of JobManager's thread dump web-frontend
displayed. */
+ @Documentation.Section(Documentation.Sections.ALL_JOB_MANAGER)
+ public static final ConfigOption<Integer> THREAD_DUMP_STACKTRACE_MAX_DEPTH
=
+ key("jobmanager.thread-dump.stacktrace-max-depth")
Review comment:
Two configuration options are more fine-grained but may introduce
complexity.
Single one is easier. Because no need to specify JM and TM's thread dump
depth, maybe single one is a better chioce.
Do you think so? If used single option, the config option should be written
in which class? in `WebOptions` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
