curcur commented on a change in pull request #18216:
URL: https://github.com/apache/flink/pull/18216#discussion_r775848542
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -144,11 +143,9 @@
private final HashMap<String, InternalKvState<K, ?, ?>>
keyValueStatesByName;
/**
- * Unwrapped changelog states used for recovery (not wrapped into e.g.
TTL).
- *
- * <p>WARN: cleared upon recovery completion.
+ * Unwrapped changelog states used for recovery (not wrapped into e.g.
TTL, latency tracking).
*/
- private final HashMap<String, ChangelogState> changelogStates;
+ private final Map<String, ChangelogState> changelogStates;
private final HashMap<String, ChangelogKeyGroupedPriorityQueue<?>>
priorityQueueStatesByName;
Review comment:
Change this to Map as well?
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -144,11 +143,9 @@
private final HashMap<String, InternalKvState<K, ?, ?>>
keyValueStatesByName;
/**
- * Unwrapped changelog states used for recovery (not wrapped into e.g.
TTL).
- *
- * <p>WARN: cleared upon recovery completion.
+ * Unwrapped changelog states used for recovery (not wrapped into e.g.
TTL, latency tracking).
*/
- private final HashMap<String, ChangelogState> changelogStates;
+ private final Map<String, ChangelogState> changelogStates;
Review comment:
Please either change all three `HashMap` to `Map` and put them into a
separate hotfix commit
Or Leave it as it is.
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -144,11 +143,9 @@
private final HashMap<String, InternalKvState<K, ?, ?>>
keyValueStatesByName;
Review comment:
Change this to Map as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
