slinkydeveloper commented on a change in pull request #18134:
URL: https://github.com/apache/flink/pull/18134#discussion_r773743200
##########
File path: flink-table/flink-table-planner/pom.xml
##########
@@ -105,23 +107,15 @@ under the License.
</exclusions>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-runtime</artifactId>
- <version>${project.version}</version>
- </dependency>
+ <!-- Table Runtime (not included in the uber) -->
<dependency>
<groupId>org.apache.flink</groupId>
-
<artifactId>flink-scala_${scala.binary.version}</artifactId>
+ <artifactId>flink-table-runtime</artifactId>
Review comment:
No, as this is a transitive dependency to run the planner. The reason to
remove provided is to simplify the setup for who's depending now on
table-planner directly (e.g. connector tests). This won't be included in the
fat jars anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
