wsry opened a new pull request #18173:
URL: https://github.com/apache/flink/pull/18173
## What is the purpose of the change
Before this patch, the LocalBufferPool#reserveSegments method may first lock
'availableMemorySegments' in LocalBufferPool and then try to lock 'factoryLock'
in NetworkBufferPool. However, other threads like TaskCanceler may first lock
'factoryLock' and then try to lock 'availableMemorySegments'. These different
locking orders can cause deadlock. This patch fixes the deadlock issue by
avoiding locking 'factoryLock' for LocalBufferPool#reserveSegments method.
## Brief change log
- Avoid locking 'factoryLock' for LocalBufferPool#reserveSegments method.
## Verifying this change
This change added a new test, without the fix, the test will fail.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
