[GitHub] [flink-ml] lindong28 commented on a change in pull request #41: [hotfix][FLIP-176] Updates onEpochWatermarkIncremented() and onIterationTerminated() to throw Exception

[GitBox]

lindong28 commented on a change in pull request #41:
URL: https://github.com/apache/flink-ml/pull/41#discussion_r772870368



##########
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/logisticregression/LogisticRegression.java
##########
@@ -362,7 +362,6 @@ private void updateModel() {
         @Override
         public void onEpochWatermarkIncremented(
                 int epochWatermark, Context context, Collector<double[]> 
collector) {
-            // TODO: let this method throws exception.

Review comment:
       hmm... why do we need to do that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org