hackergin commented on a change in pull request #18058:
URL: https://github.com/apache/flink/pull/18058#discussion_r772863211



##########
File path: 
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/table/IndexGeneratorFactory.java
##########
@@ -240,6 +273,11 @@ boolean checkIsDynamicIndexWithFormat(String index) {
             return dynamicIndexTimeExtractPattern.matcher(index).matches();
         }
 
+        /** Check generate a dynamic index is based on processing time. */
+        boolean checkIsDynamicIndexWithProcTimeFormat(String index) {

Review comment:
       @leonardBang  I agree with you , and I'll change the describetion  of 
this issue/PR later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to