Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2216#discussion_r71169047
--- Diff: flink-metrics/flink-metrics-ganglia/pom.xml ---
@@ -68,20 +68,27 @@ under the License.
<build>
<plugins>
<plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <version>2.4</version>
- <configuration>
- <descriptorRefs>
-
<descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- </configuration>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>2.4.1</version>
<executions>
+ <!-- Run shade goal on package phase -->
<execution>
- <id>make-assembly</id>
+ <id>shade-flink</id>
<phase>package</phase>
<goals>
- <goal>single</goal>
+ <goal>shade</goal>
</goals>
+ <configuration
combine.self="override">
+ <artifactSet>
+ <includes>
+
<include>org.apache.flink:flink-metrics-dropwizard</include>
+
<include>io.dropwizard.metrics:metrics-core</include>
+
<include>io.dropwizard.metrics:metrics-ganglia</include>
+
<include>info.ganglia.gmetric4j:gmetric4j</include>
--- End diff --
Sure that we don't need `org.acplt:oncrpc:jar:1.0.7:compile` which is a
transitive dependency of `info.ganglia.gmetric4j` in the fat jar? Have you
tried running ganglia on a cluster with this shaded jar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
