PatrickRen commented on a change in pull request #18128:
URL: https://github.com/apache/flink/pull/18128#discussion_r770349706
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainers.java
##########
@@ -160,6 +162,7 @@ public void stop() {
restClusterClient.close();
}
this.taskManagers.forEach(GenericContainer::stop);
+ deleteJobManagerTemporaryFiles();
Review comment:
I prefer to keep it for deleting temporary directories that are created
in `FlinkContainersBuilder`. JM only removes dirs and files it created inside
the temp dir (`/flink/checkpoint/{jobid}/xxx`) but not the temp dir itself
(`/flink/checkpoint`).
Currently the image will be deleted when JVM exits. The image will be kept
only if you use `new ImageFromDockerfile(name, false)`, where the second
parameter is `deleteOnExit`.
Code for building Flink image:
https://github.com/apache/flink/blob/master/flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkImageBuilder.java#L215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
