Github user chadnickbok commented on a diff in the pull request:
https://github.com/apache/flink/pull/2260#discussion_r71062357
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java
---
@@ -50,8 +50,14 @@ public static AmazonKinesisClient
createKinesisClient(Properties configProps) {
awsClientConfig.setUserAgent("Apache Flink " +
EnvironmentInformation.getVersion() +
" (" +
EnvironmentInformation.getRevisionInformation().commitId + ") Kinesis
Connector");
- AmazonKinesisClient client =
- new
AmazonKinesisClient(AWSUtil.getCredentialsProvider(configProps).getCredentials(),
awsClientConfig);
+ AWSCredentialsProvider credentialsProvider =
AWSUtil.getCredentialsProvider(configProps);
+
+ if (credentialsProvider != null) {
+ AmazonKinesisClient client =
+ new
AmazonKinesisClient(credentialsProvider.getCredentials(), awsClientConfig);
+ } else {
+ AmazonKinesisClient client = new
AmazonKinesisClient(awsClientConfig);
+ }
--- End diff --
Well that's embarassing - I was so sure I compiled this first! That's what
I get for pushing a pull request late on a Friday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
