slinkydeveloper commented on a change in pull request #18088:
URL: https://github.com/apache/flink/pull/18088#discussion_r769376357
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -620,10 +620,16 @@ public static String getFormatPrefix(
Class<T> factoryClass, DynamicTableFactory.Context context) {
final String connectorOption =
context.getCatalogTable().getOptions().get(CONNECTOR.key());
if (connectorOption == null) {
- throw new ValidationException(
- String.format(
- "Table options do not contain an option key '%s'
for discovering a connector.",
- CONNECTOR.key()));
+ ManagedTableFactory factory =
Review comment:
More than having an empty connector id and hardcoding the discovery of
`ManagedTableFactory`, I wonder if we can have a connector id for that, and
then we inject it from `TableEnvironmentImpl` every time we parse a table which
doesn't provide a `connector` value in the table options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
