eskabetxe commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-993259130
> > @leonardBang could you check again, I add both tests and address all comments > > Thanks @eskabetxe for the improvements, but unfortunately I found we need consider more about the source implementation, I implemented a basic here [1] [leonardBang@6da60f3](https://github.com/leonardBang/flink/commit/6da60f30e977daf91b8a1c2dd9258ccb5fd13275), could you improve this base the draft. @leonardBang done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org