liufangqi commented on pull request #18059: URL: https://github.com/apache/flink/pull/18059#issuecomment-993053550
> Hi @liufangqi, I think this is headed in a right direction. > > Few things that need to be addressed before merging: > > 1. We should align the dependency version with the CI pipelines. [1] > 2. There is already a 2.8.5 version. Is there anything blocking us for using this one? > 3. For **now** we have to maintain runtime compatibility. > > More detailed explanation for 3) would be, that this changes the dependency for both compiling and the testing. We still need to be able to run a test suite against `2.4.x`. After merging this, it would sort of work, but if you think about it in context of [FLINK-25029](https://issues.apache.org/jira/browse/FLINK-25029) [2] that brought us here, it breaks once you make a backward incompatible change. What we need to have is the build to uses different version for compilation and for running tests (the second option will be used by the CI to ensure backwards compatibility). > > [1] https://github.com/apache/flink/blob/master/azure-pipelines.yml#L80 [2] https://issues.apache.org/jira/browse/FLINK-25029 > > I'll start a thread on ML, about bumping minimal supported version for Hadoop, but until that has been agreed upon by the community we can not simply drop runtime support for `2.4.x`. Hi, @dmvk ,THX for your reply, The following is the response to your question: 1. I will change the azure-pipelines.yml to align the dependency version with pom. 2. yeah, you are right, 2.8.5 may be more suitable than 2.8.4, the reason I chose 2.8.4 is just I used it before. 3. I think the CI work is enough to ensure that 2.8.5 is compatibility, am I right? --- So whether the work I should do next is just change the pom & ci script Hadoop version? And two things I should observe are: 1. whether CI work success. 2. whether the community agree the Hadoop version upgrade. --- The above is my understanding, if I am wrong or there are any thing other I need to push, just ping me. I will build a new commit soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
