rkhachatryan commented on a change in pull request #17774:
URL: https://github.com/apache/flink/pull/17774#discussion_r767807433
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DeactivatedCheckpointCompletedCheckpointStore.java
##########
@@ -69,6 +69,11 @@ public SharedStateRegistry getSharedStateRegistry() {
throw unsupportedOperationException();
Review comment:
Yes, the javadoc is wrong (though it wasn't changed in this PR).
It doesn't sound like it **must** throw an exception instead of NO_OP.
Anyways, I can fix javadoc and also list `getRegistry` as an allowed method
in it (I'm afraid that throwing an exception or returning throwing
`SharedStateRegistry` can break something).
WDYT?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DeactivatedCheckpointCompletedCheckpointStore.java
##########
@@ -69,6 +69,11 @@ public SharedStateRegistry getSharedStateRegistry() {
throw unsupportedOperationException();
Review comment:
Yes, the javadoc is wrong (though it wasn't changed in this PR).
It doesn't sound like it **must** throw an exception instead of NO_OP.
Anyways, I can fix javadoc and also list `getRegistry` as an allowed method
in it (I'm afraid that throwing an exception or returning throwing
`SharedStateRegistry` can break something).
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
