Github user uce commented on the issue:
https://github.com/apache/flink/pull/2252
Looks very good! The test failures seem unrelated:
- ClientTest: https://issues.apache.org/jira/browse/FLINK-4220 (newly
created)
- JobManagerHACheckpointRecoveryITCase:
https://issues.apache.org/jira/browse/FLINK-3516 (known instability)
- Travis Scala dependency issue
The added tests and refactorings are very readable.
I think this is good to merge mod some minor inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
