[
https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378902#comment-15378902
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4194 at 7/15/16 7:22 AM:
---------------------------------------------------------------------
I wonder if it would actually make more sense to name the method
{{isEndOfShard()}}, and only stop a single {{ShardConsumer}} to stop consuming
a shard when its {{true}}. So, in a sense this is opting to go with the
behaviour of the {{FlinkKafkaConsumer08}}, but renaming the method to match
this behaviour.
This way the intention of the method will be much more defined, and probably
more useful for the user too? Like you said, currently {{isEndOfStream()}}
behaviour can't really be defined, and I find it quite confusing myself, when
the stream is continuing to fetch data (from other shard/partitions) even when
the condition is met.
What do you think?
was (Author: tzulitai):
I wonder if it would actually make more sense to name the method
{{isEndOfShard()}}, and only stop a single {{ShardConsumer}} to stop consuming
a shard when its {{true}}. This way the intention of the method will be much
more defined, and probably more useful for the user too? Like you said,
currently {{isEndOfStream()}} behaviour can't really be defined, and I find it
quite confusing myself, when the stream is continuing to fetch data (from other
shard/partitions) even when the condition is met.
What do you think?
> KinesisDeserializationSchema.isEndOfStream() is never called
> ------------------------------------------------------------
>
> Key: FLINK-4194
> URL: https://issues.apache.org/jira/browse/FLINK-4194
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Tzu-Li (Gordon) Tai
>
> The Kinesis connector does not respect the
> {{KinesisDeserializationSchema.isEndOfStream()}} method.
> The purpose of this method is to stop consuming from a source, based on input
> data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
