[ 
https://issues.apache.org/jira/browse/FLINK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378657#comment-15378657
 ] 

ASF GitHub Bot commented on FLINK-3630:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2254

    [FLINK-3630] [docs] Little mistake in documentation

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 
3630_little_mistake_in_documentation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2254
    
----
commit c659b51803545f067192de2760e0d7df958ef236
Author: Greg Hogan <c...@greghogan.com>
Date:   2016-07-14T18:42:55Z

    [FLINK-3630] [docs] Little mistake in documentation

----


> Little mistake in documentation
> -------------------------------
>
>                 Key: FLINK-3630
>                 URL: https://issues.apache.org/jira/browse/FLINK-3630
>             Project: Flink
>          Issue Type: Bug
>          Components: DataSet API, Documentation
>    Affects Versions: 1.0.0
>            Reporter: Riccardo Diomedi
>            Assignee: Greg Hogan
>            Priority: Minor
>              Labels: documentation
>
> in section "GroupCombine on a Grouped DataSet" of the following link: 
> https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/batch/dataset_transformations.html#groupreduce-on-grouped-dataset
> there is a little mistake in java code in both combine and reduce method(it's 
> the same mistake). The variable "word" is defined in the scope of the for 
> loop so it cannot be used in collect method.
> Possible solution could be to initialise the variable before the for and 
> assign a value inside the for.
> Something like:
> int count = 0;
> String word;
> for (String record : words) {
>     word = record;
>     count++;
> }
> out.collect(new Tuple2(word, count)); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to