Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2249#discussion_r70881905
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -475,23 +484,23 @@ public YarnClusterClient retrieveCluster(
                        CommandLine cmdLine,
                        Configuration config) throws 
UnsupportedOperationException {
     
    -           // first check for an application id
    -           if (cmdLine.hasOption(APPLICATION_ID.getOpt())) {
    -                   String applicationID = 
cmdLine.getOptionValue(APPLICATION_ID.getOpt());
    +           // first check for an application id, then try to load from 
yarn properties
    +           String applicationID = 
cmdLine.hasOption(APPLICATION_ID.getOpt()) ?
    +                           cmdLine.getOptionValue(APPLICATION_ID.getOpt())
    +                           : loadYarnPropertiesFile(cmdLine, config);
    +
    +           if(null != applicationID) {
    --- End diff --
    
    missing space after if


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to